-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FluxCD Application Management #743
Conversation
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 51.09% 53.65% +2.55%
==========================================
Files 171 181 +10
Lines 10141 10668 +527
==========================================
+ Hits 5182 5724 +542
+ Misses 4666 4627 -39
- Partials 293 317 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f963c56
to
a9a1cc9
Compare
I encountered a strange problem when I wrote unit test due to the version of controller-runtime. I use code like this I found the root cause is this issue, but the PR which fix this issue was merged only in the 0.9.x version of controller-runtime, I tried to update the controller-runtime v0.6.3 => v0.9.7 but It caused too many changes. So I Added code manually like this in the unit test: schema.AddKnownTypeWithName(apischema.GroupVersionKind{
Group: "helm.toolkit.fluxcd.io",
Version: "v2beta1",
Kind: "HelmReleaseList",
}, &unstructured.UnstructuredList{}) And the fluxcd project actually provide the module which include the HelmRelease type for convenience. But It also need higher version of controller-runtime. Is it possible to update the controller-runtime version when it arrive version 1.0 or LTS ? |
When I delete the gitops.kubesphere.io/Application I want to delete all HelmReleases belong to it. I can implement it just set the all HelmReleases' Is there any different between the |
I'm not sure if I understand it correctly. But it might be helpful for you. IMO, the The See also https://kubernetes.io/blog/2021/05/14/using-finalizers-to-control-deletion/ |
Thanks a lot, this is very helpful. |
296b3d1
to
d8a7a2d
Compare
/test ? |
@chengleqi: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kubesphere/sig-devops @LinuxSuRen |
@lxm: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kubesphere/sig-devops |
You can retrigger the actions once you close and reopen this PR. |
while controller-runtime version has been updated to v0.12.3 with #788. |
…on on FluxCD HelmRelease and Kustomization
Signed-off-by: chengleqi <leqicheng@stu.xidian.edu.cn>
Change Named design Signed-off-by: chengleqi <leqicheng@stu.xidian.edu.cn>
Signed-off-by: chengleqi <leqicheng@stu.xidian.edu.cn>
10ae430
to
24226d2
Compare
Signed-off-by: chengleqi <leqicheng@stu.xidian.edu.cn>
24226d2
to
60556b3
Compare
Please try not to use force action. I need to review all files one by one if you push the code with the force option. |
Signed-off-by: chengleqi <leqicheng@stu.xidian.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: chengleqi <leqicheng@stu.xidian.edu.cn>
lgtm @kubesphere/sig-devops @LinuxSuRen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind feature
/kind design
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #717 , #718
Special notes for reviewers:
Please check the following list before waiting reviewers:
Does this PR introduce a user-facing change??